Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt spec 96bcd043aa8a28f6f64c95ad61329765f01de1ba #276

Merged
merged 1 commit into from
Oct 5, 2015
Merged

Adapt spec 96bcd043aa8a28f6f64c95ad61329765f01de1ba #276

merged 1 commit into from
Oct 5, 2015

Conversation

runcom
Copy link
Member

@runcom runcom commented Sep 18, 2015

Fixes #274

@runcom runcom mentioned this pull request Sep 18, 2015
Closed
@runcom runcom force-pushed the adapt-spec-96bcd043aa8a28f6f64c95ad61329765f01de1ba branch 4 times, most recently from ca6a6cf to 5093b08 Compare September 18, 2015 02:30
@wking wking mentioned this pull request Sep 18, 2015
Closed
@runcom runcom force-pushed the adapt-spec-96bcd043aa8a28f6f64c95ad61329765f01de1ba branch 4 times, most recently from 2e090e9 to d7edd30 Compare September 18, 2015 16:58
@runcom runcom mentioned this pull request Sep 19, 2015
Merged
@runcom runcom force-pushed the adapt-spec-96bcd043aa8a28f6f64c95ad61329765f01de1ba branch 3 times, most recently from 4c0d567 to ac80ee8 Compare September 22, 2015 22:14
@runcom runcom mentioned this pull request Sep 23, 2015
Merged
@tiborvass
Copy link
Contributor

Ping @LK4D4 @crosbymichael

@crosbymichael
Copy link
Member

LGTM

@runcom
Adjust runc to new opencontainers/specs version
c6e406a 
Godeps: Vendor opencontainers/specs 96bcd04

Fix a bug where it's impossible to pass multiple devices to blkio
cgroup controller files. See opencontainers#274

Signed-off-by: Antonio Murdaca <[email protected]>
@runcom runcom force-pushed the adapt-spec-96bcd043aa8a28f6f64c95ad61329765f01de1ba branch from ac80ee8 to c6e406a Compare October 3, 2015 10:26
@runcom
Copy link
Member Author

runcom commented Oct 3, 2015

I've rebased this, though it seems the specs version I'm importing here is quite old now. I'll vendor the latest commit and adapt code if it's ok for you @crosbymichael @LK4D4 @mrunalp

@thaJeztah
Copy link
Member

Looks like this is blocking two PR's in docker (moby/moby#13959 (comment)), any chance of moving this forward? ❤️

@crosbymichael
Copy link
Member

ping @LK4D4 @vishh @mrunalp could u guys checkout these changes. It's pretty straight forward.

@mrunalp
Copy link
Contributor

mrunalp commented Oct 5, 2015

Reviewing...

@mrunalp
Copy link
Contributor

mrunalp commented Oct 5, 2015

LGTM

mrunalp pushed a commit that referenced this pull request Oct 5, 2015
Merge pull request #276 from runcom/adapt-spec-96bcd043aa8a28f6f64c95…
2239755 
…ad61329765f01de1ba

Adapt spec 96bcd04
@mrunalp mrunalp merged commit 2239755 into opencontainers:master Oct 5, 2015
@runcom runcom deleted the adapt-spec-96bcd043aa8a28f6f64c95ad61329765f01de1ba branch October 5, 2015 23:44
@runcom
Copy link
Member Author

runcom commented Oct 5, 2015

I'll update docker now, thanks @crosbymichael @mrunalp

@thaJeztah
Copy link
Member

Thanks all!

stefanberger pushed a commit to stefanberger/runc that referenced this pull request Sep 8, 2017
Merge pull request opencontainers#276 from vbatts/schema
fae9a3e 
source and schema: differentiate with examples
stefanberger pushed a commit to stefanberger/runc that referenced this pull request Sep 8, 2017
@wking
specs-go/config: Fix 'SelinuxProcessLabel' -> 'SelinuxLabel'
59333dc 
The label changed in 5a8a779 (Move process specific settings to
process, 2016-03-02, opencontainers#329) and 7bf06d5 (source and schema:
differentiate with examples, 2015-12-18, opencontainers#276) missed this instance
when rebasing around opencontainers#329.

Signed-off-by: W. Trevor King <[email protected]>
stefanberger pushed a commit to stefanberger/runc that referenced this pull request Sep 8, 2017
@wking
config: Make Markdown canonical
160b4a2 
Also:

* Update the link to Go bindings after 7bf06d5 (source and schema:
  differentiate with examples, 2015-12-18, opencontainers#276).
* Add a reference to the JSON Schema after cdcabde (schema: JSON
  Schema and validator for `config.json`, 2016-01-19, opencontainers#313).

It's pretty clear that the Go bindings cannot be canonical on their
own, because they do not define limits (e.g. the 0 through 512 range
for FileMode).  The JSON Schema is closer, but still does not cover
everything (e.g. "a directory must exist at root.path").  Both the Go
bindings and the JSON Schema could grow to cover the full spec by
adding that sort of thing to comments and descriptions, but that's not
how things seem to be working now.

Signed-off-by: W. Trevor King <[email protected]>
stefanberger pushed a commit to stefanberger/runc that referenced this pull request Sep 8, 2017
@wking
project: Update link to version.go now that it's in specs-go/
2123330 
Catch up with 7bf06d5 (source and schema: differentiate with examples,
2015-12-18, opencontainers#276).

Signed-off-by: W. Trevor King <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status/0-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@runcom @tiborvass @crosbymichael @thaJeztah @mrunalp @GordonTheTurtle